Hi,
On 2017/05/20 19:36, Martin Thomson wrote:
On Sat, May 20, 2017 at 4:55 AM, Kris Maglione <kmagli...@mozilla.com> wrote:
Can we make some effort to get clean warnings output at the end of standard
builds? A huge chunk of the warnings come from NSS and NSPR, and should be
easily fixable.
Hmm, these are all -Wsign-compare issues bar one, which is fixed
upstream. We have an open bug tracking the warnings
(https://bugzilla.mozilla.org/show_bug.cgi?id=1307958 and specifically
https://bugzilla.mozilla.org/show_bug.cgi?id=1212199 for NSS).
I am surprised that
https://bugzilla.mozilla.org/show_bug.cgi?id=1307958
was mentioned and when I looked at it, it was filed by me. :-)
The patches there were filed about four months ago, and recently I
noticed that I need to add a few more changes presumably due to code
changes, AND I found that I must have disabled a few modules from
compiling to build C-C TB, and a full M-C FF build with -Wsign-compare
and warning as error setting needs still a few more changes (not that many).
I will upload the latest patches later.
I agree that disabling this check is a little uncomfortable for crypto
code.
My patch is pasting over the mismatched comparison by
casting one type to the other. In most of the cases, I see that the
value should not go that high for wraparound near 2^31, etc. but still
I would have inserted an assert() to detect a problematic situation if I
have infinite amount of time to spend reading the code.
My patches would alert astute coders to look at the places where the
problem may arise and insert assert() appropriately.
TIA
NSS is built with -Werror separately, but disables errors on
-Wsign-compare. Disabling those warnings for a Firefox build of NSS
wouldn't be so bad now that we share gyp config. Based on a recent
build, that's 139 messages (add 36 if you want to add nspr).
I've spent a little time looking into the real issues. Fixing
requires some care, since it touches ABI compat in many places.
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
