On Mon, Apr 17, 2017 at 9:21 PM, Nicholas Nethercote <[email protected] > wrote:
> > That is why we have links to the bug. Bug should always be the unite of > > truth telling > > why some change was done. Bugs tend to have so much more context about > the > > change than any individual commit message can or should have. > > With all due respect, I think you have a different view on this to at least > some people (and perhaps most people). > FWIW I agree with Olli. I look for a good one line summary of the change, but beyond that I find you really do need to look at the bug to get the full context. I don't object to people writing longer commit messages, but that information needs to be in the bug. Our tools today (splinter and mozreview) don't do that automatically AFAIK. I think there is an hg extension you can get to do it with splinter. I find it much more useful to have an explanatory comment in the bug since I can see it in context with everything else, links, etc. Its also clear what version of the patch its associated with. Commit messages often are not updated with changes to the patch and can be slightly wrong. Finally, as has been mentioned in previous threads, any real nuance should be in the patch itself as comments. Both bugs and code comments are searchable and more easily discoverable. The tools for finding information in blame are much harder to use. I greatly prefer bug and code comments. Just my two cents. (I wasn't going to chime in here, but felt compelled since Olli's view was being cast as rare.) Ben _______________________________________________ dev-platform mailing list [email protected] https://lists.mozilla.org/listinfo/dev-platform
