On Fri, Mar 17, 2017 at 12:03:30PM +0200, Henri Sivonen wrote: > It seems that our Rust bindings for nsresult are part of Stylo, but > Stylo isn't yet a guaranteed part of the build.
FWIW those bindings are only checked-in into Servo for CI purposes (so we can build the Gecko version of the style crate in Servo's CI without requiring Gecko). The real bindings are generated at build-time. > Until Stylo becomes a mandatory part of the build, what's the proper > way to return nsresult from Rust such that it works with or without > Stylo enabled? We could try to split the compontents/style/gecko_bindings directory out of stylo, I guess, though that'd require bindgen (and libclang) to be enabled for everyone. Also, we could do it all-at-once, which is a bit more risky because bindgen had some build problems in some machines with some exotic C++ headers I'm trying to sort out, but we could also extract an nsresult crate much like the nsString bindings, which should be pretty straight-forward and shouldn't have those problems. If everyone's fine with the libclang 3.9+ dependency, I guess it's fine to do so. Otherwise we could checkout a static version of them, but they'd need to be updated each time any error code changes. Fedora didn't have libclang 3.9 packages IIRC, but that could've changed. -- Emilio
signature.asc
Description: PGP signature
_______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
