This has actually been confusing me in reviews, since the commit-message looks like another file in the diff. Not sure of a better way to show this isn't going to be a file when checked in, but with the way it's shown as part of the change set in the patch right now, it's hard to discern.
On Thu, Mar 9, 2017 at 11:53 AM, Mike Conley <mcon...@mozilla.com> wrote: > Incidentally, MozReview now allows you to provide feedback on the commit > message in the diffviewer. > > On Mar 9, 2017 2:47 PM, "Ehsan Akhgari" <ehsan.akhg...@gmail.com> wrote: > > > I review a large number of patches on a typical day, and usually I have > to > > spend a fair amount of time to just understand what the patch is doing. > As > > the patch author, you can do a lot to help make this easier by *writing > > better commit messages*. Starting now, I'm going to try out a new > practice > > for a while: I'm going to first review the commit message of all patches, > > and if I can't understand what the patch does by reading the commit > message > > before reading any of the code, I'll r- and ask for another version of > the > > patch. > > > > I thank you in advance for your cooperation by writing great commit > > messages. Happy hacking! > > > > Cheers, > > -- > > Ehsan > > _______________________________________________ > > dev-platform mailing list > > dev-platform@lists.mozilla.org > > https://lists.mozilla.org/listinfo/dev-platform > > > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
