On 02/09/2017 03:26 AM, Botond Ballo wrote:
As far as I can tell, ISize and BSize are methods on mozilla::LogicalRect, which does not derive from BaseRect, and as such would not be affected.
Here's LogicalRect::ISize(): https://dxr.mozilla.org/mozilla-central/rev/5e17f9181c6cb0968966280d1c1d96e725702af1/layout/generic/WritingModes.h#1552-1556 'mRect' there is an nsRect, which you propose to change, right? So every call will now need to calculate "x2 - x1" there, IIUC. (same for BSize(), Width(), Height(), Size(), and the ctor taking a LogicalSize (need to calculate x2/y2)) It's hard to speculate about performance of something like this where some operations becomes faster and some slower. But given the scope of the change I would like to see measurements that shows this is a performance win overall. /Mats _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
