On 8/8/2016 15:35, Boris Zbarsky wrote:
On 8/8/16 9:02 AM, Xidorn Quan wrote:
Would that make it harder for people to jump into some file directly via
history (or awesome bar)?
I _think_ the suggestion is as follows:
When you click a link to a particular line in dxr, that would normally
navigate from https://dxr/foo to https://dxr/foo#lineno. Instead, have
it navigate to https://dxr/rev/foo#lineno.
One way to do it, yes.
If done as a straight navigation, it's annoying, because it reloads
the page.
If we want to update URL in the address bar, then yes. But there could
be an option to copy the link a different way than going to URL bar and
do Ctrl-C, like a button "copy this code perma link".
So instead, do it as a pushState that changes the url.
Where is the bad interaction with the awesome bar?
I guess there's the question of where links from search results should
go...
In my humble opinion, should go the rev/xxx version. And the search
result page URL may be added the revision as well (e.g. in fragment?)
-hb-
-Boris
_______________________________________________
dev-platform mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-platform
_______________________________________________
dev-platform mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-platform
