On 5/2/16 2:30 PM, Aryeh Gregor wrote:
What's the problem with standardizing completely if we pick the limit
to be low enough that we have plenty of room?

Please define "Plenty of room"?

For a 900KB stack (what we have on Windows, per <http://mxr.mozilla.org/mozilla-central/source/js/xpconnect/src/XPCJSRuntime.cpp#3440>) 512 DOM nodes deep corresponds to ~2KB per DOM node. 200 deep corresponds to 5KB.

Now quick, tell me how much stack space MSVC with PGO is using for the combination of ElementRestyler::Restyle and ElementRestyler::RestyleChildren and ElementRestyler::RestyleContentChildren (which is the unit of recursive work when recalculating styles down the tree). How much stack space will it use with the next MSVC release? How much stack space will it use if we change the ElementRestyler struct some (note that this goes on the stack before the Restyle() call on it)?

The answer at least for me is that I don't know. But I bet it's quite specific to particular code paths and compilers....

-Boris
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to