On Sat, Apr 30, 2016 at 6:46 AM, Chris Peterson <cpeter...@mozilla.com> wrote: > > In theory, nsresult seems like an important type to check. > > That said, I once tried building Gecko with `#define NS_IMETHOD > MOZ_WARN_UNUSED_RESULT NS_IMETHOD_(nsresult)`. There were over 10,000 > warnings for XPCOM method callers not checking nsresult return values, so > this approach does not seem practical. :(
I tried the same thing. I started working through them, but immediately hit numerous functions where it was unclear (to me) whether not checking was reasonable or not. The incremental approach that has been used to increase the coverage of compiler warnings serves as a good example in this case. We have too much code to do it any way other than gradually. Nick _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
