On 04/08/2016 07:38 PM, Nick Fitzgerald wrote:
On Fri, Apr 8, 2016 at 9:29 AM, Birunthan Mohanathas <
birunt...@mohanathas.com> wrote:

On 8 April 2016 at 18:10, Kartikaya Gupta <kgu...@mozilla.com> wrote:
Others?

enum class OptionD {
   SentenceCaseValues,
   ThisWontBeConfusedWithOtherThings
   // ... because you need to use OptionD::ThisWontBeConfusedWithOtherThings
};


Strong +1 for enum classes. That way we don't need any more nasty prefixing
and can
​instead ​
rely on the compiler
​​
and type system.


enum classes are great, but I'd still use prefix for the values. Otherwise the 
values look like types - nested classes or such.
(Keeping my reviewer's hat on, so thinking about readability here.)



-Olli
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to