It may be a stupid question as my understanding of this part of the code is flaky.
But don't we need at least a Flush_Style to make sure the CSS that tries to use background-image will start triggering images decoding and block the onload event ? I just want to make sure it won't create flickering effects when app author tries to reveal their page content after the onload event. On Fri, Nov 27, 2015 at 8:29 AM, Xidorn Quan <quanxunz...@gmail.com> wrote: > On Fri, Nov 27, 2015 at 6:15 PM, Axel Hecht <l...@mozilla.com> wrote: > > On 11/27/15 4:09 AM, Robert O'Callahan wrote: > >> > >> On Fri, Nov 27, 2015 at 3:59 PM, Boris Zbarsky <bzbar...@mit.edu> > wrote: > >> > >>> On 11/26/15 9:24 PM, Robert O'Callahan wrote: > >>> > >>>> We've always done it, but I can't think of any good reasons. > >>>> > >>> > >>> I've tried to fix this in the past and ran into two problems. > >>> > >>> The first problem was that some tests failed as a result. This is > >>> somewhat minor, really. > >>> > >>> The second problem, pointed out by the first, is that some tests > stopped > >>> testing what they mean to be testing, because all of our reftests and > >>> crashtests assume layout gets flushed onload, so they can test dynamic > >>> behavior by doing stuff after that. > >>> > >>> See https://bugzilla.mozilla.org/show_bug.cgi?id=581685 for details. > I > >>> haven't had a chance to get back and really figure this out, though we > >>> should. > >> > >> > >> > >> Mmmm. This could be a significant win! > >> > >> Rob > >> > > > > I wonder, how much of the web could rely on this, given our tests do? > > I don't think the web would be affected by this change, because if the > page do something in onload which requires a layout, the layout would > always happen no matter whether we do this in advance. > > Our tests relying on this is probably because certain bugs are only > detectable when we apply content/style change after a layout flush. > > - Xidorn > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
