On Mon, Aug 31, 2015 at 12:10 PM, Chris Peterson <cpeter...@mozilla.com> wrote: > > When I said we have typically suppressed third-party warnings, I meant with > CXXFLAGS += ['-Wno-whatever'] in moz.build
I'm not convinced this is worth the effort for "true" third-party code. The next time we update there might be new warnings that we need to suppress. I guess it depends on the goal... - To avoid warnings-as-errors bustage? (Just enable ALLOW_COMPILER_WARNINGS and don't try to be precise.) - To avoid unavoidable warnings showing up in the build output? (Maybe... though just turning off all warnings for such code might be easier and more future-proof. Alternatively, if we get to the point where the only place ALLOW_COMPILER_WARNINGS is enabled is third-party code directories, then it would actually be reasonable to ignore all warnings in build output. Hmm.) Nick _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
