On Fri, Jul 24, 2015 at 1:59 AM, Nicholas Nethercote <[email protected]> wrote: > On Fri, Jul 24, 2015 at 5:45 PM, Jonas Sicking <[email protected]> wrote: >> On Thu, Jul 23, 2015 at 10:16 PM, Nicholas Nethercote >> <[email protected]> wrote: >>> I wonder if converting all the uses of PLHashTable into PLDHashTable >>> would instead be a better approach. >> >> Yes please! Though IIRC they are have different performance >> characteristics, which might make that challenging in some cases. > > The only case I'm aware of where PLDHashTable is inferior is that it > can be wasteful of space if individual elements are large, because you > have all those empty entries. But that can be worked around by making > elements have type |T*| instead of |T|.
I thought that PLHashTable also allowed you to hold pointers to entries, whereas PLDHashTable move them around any time it rehashes. But I might misremember since in a quick skim of NodeInfoManager we don't seem to take advantage of anything like that. / Jonas _______________________________________________ dev-platform mailing list [email protected] https://lists.mozilla.org/listinfo/dev-platform
