However, I do believe in the following scenario: - oh, there is an assertion warning, it's not my fault, let's allow one assertion; - wait, there are a few, let's allow several; - oh, they are intermittent, let's make it an interval; - [at some point, some of the warnings are fixed, but nobody realized]; - [at some point, something causes other warnings to be triggered, but nobody realized]; - we realize the regression years later.
I am almost sure that I have witnessed this kind of scenario while working on Session Restore. It used to cause assertion warnings at some place in the DOM, which were not documented in any bug that I could find, and nobody cared. Also, second issue of the current approach: I have seen very few (if any) bugs yet that documents exactly the assertion warnings that they trigger, explaining why they are normal and should be ignored. That's a codetrap for whoever comes next. Requiring a test to actively opt-in for whitelisting a specific assertion warning means that there is a good place to r- the test until this is documented. Frankly, I'm really sick of warnings, and anything we can do to make them more actionable would be one step towards restoring sanity in our tests and in some parts of our codebase. Best regards, David On 10/06/15 06:39, Ehsan Akhgari wrote: > On 2015-06-09 8:33 AM, Robert O'Callahan wrote: >> Does anyone know of a case where we had a regression that traded one >> assertion for another? I don't. > > I don't either. Which is why I believe that David's point, while being > perfectly valid in theory, doesn't matter a lot in practice. > > Also, you need to consider the fact that one assertion appearing in > place of another one in the same commits going into one build compared > to the previous not breaking *anything else* or have any observable > effect on all of our test suites is extremely unlikely. -- David Rajchenbach-Teller, PhD Performance Team, Mozilla _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
