On Fri, May 08, 2015 at 09:53:54AM +1200, Karl Tomlinson wrote: > Ehsan Akhgari writes: > > >> This seems similar to the compiler warning situation. > >> Usually at least, I don't think we should automatically modify the > >> code in line with how the compiler reads the code just to silence > >> the warning. Instead the warning is there to indicate that a > >> programmer needs to check the code. > > > > These cases bear no similarity whatsoever. I can't think of any > > compiler warnings that can be automatically fixed without changing > > the meaning of the program. > > The warning that you are proposing to fix here is > -Woverloaded-virtual. > > At least once we can build with this warning enabled, I recommend > making this warning fatal instead of covering over it by adding an > override annotation that the author may have never intended.
It *is* enabled and fatal, but there are a few places that disable it. Mike _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
