On Tue, Apr 21, 2015 at 02:50:43PM -0400, Andrew Halberstadt wrote:
> On 21/04/15 02:41 PM, Chris Peterson wrote:
> >On 4/21/15 11:27 AM, Ehsan Akhgari wrote:
> >>>I agree that it shouldn't be 10%. Hopefully once we have the autolander
> >>>this will be a non-issue.
> >>
> >>It would be a huge help if someone made a little tool which would show
> >>you how often one specific person breaks inbound.  I would definitely
> >>like to know whether I'm closer to 10% or 100% myself.
> >
> >Something like the "Try High Score" ranking for inbound backouts would
> >be straightforward to automate:
> >
> >https://secure.pub.build.mozilla.org/builddata/reports/reportor/daily/highscores/highscores.html
> 
> This could be effective, but if not implemented with care it could also be
> very de-motivating, especially for a well-intentioned contributor.

Here are a few crude stats, gathered over the last 25271 changesets,
assuming my pattern matching worked properly:

- 1438 changesets were backed out (~5.7%)
- 123 of those backouts were for changes whose authors have less than 10
  changesets in the range. The total number of changesets from those
  authors all grouped together is 405, so ~30.4% backout rate for people
  with few patches. There are 83 authors in this category.
- there are 214 authors with 10 changesets or more in the range.
- the median backout rate for those 214 authors is 7.7%.
- the average backout rate for the same authors is 10.5%. There are 76
  authors above average.
- there are 27 of those authors above 20% backout rate.
- there are 11 of those authors above 30% backout rate.
- the biggest backout rate for those authors is 48.8%.

I took 10 changesets as an arbitrary limit below which the rate is not
really interesting. Note authors are determined by email address and
are not deduped (if people are using different email addresses, they
count as multiple authors)

To give an example why I took the backout rate instead of the raw
number: by raw number, ehsan is 2nd with 47 backouts... but he also
landed 594 changesets, so his rate is only slightly above the median.
Also, the biggest backout rate if counting all authors is 100%: a few
people have had one patch landed and backed out.

That being said, the median and average above are only considering
authors with 10 and more changesets in the last 25271 for whom there
*was* a backout. If taking everyone into account, the median backout
rate is... 0.  The average is ~6.7%.

And for what it's worth, excluding sheriffs and b2gbumper, the biggest
number of changesets pushed by someone without a backout in the last
25271 changesets is 126. There are only 38 authors, of the total 827
with more changesets pushed.

Mike
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to