I just pushed this to inbound (rev 0c030f97a04f). Jan
On Thu, Mar 26, 2015 at 11:52 PM, Jan De Mooij <jdemo...@mozilla.com> wrote: > Hi all, > > After some discussion, we want to switch SpiderMonkey and XPConnect style > for pointers/references from |T *p| to |T* p| (and |T &ref| to |T& ref|). > This matches the rest of the project and will make life easier for > developers working on multiple parts of the tree. > > Although this will break a lot of patches, you can run the script in bug > 1144366 [0] on patch files too and they should apply cleanly after that > (make sure you have backups): > > restyle.py --files patch1 [patch2..] > > The plan is to land this change next weekend or early next week. We'll > likely land this on aurora/beta/ESR as well, to avoid painful uplifts. > > Finally, a common argument for the current style is that it might be > clearer when you declare multiple pointers, like this: > > int *x, *y; // x and y are int* > > However, I think this is pretty confusing either way, and both our style > guide [1] and Stroustrup [2] suggest sticking to one pointer per > declaration. I'll write a separate patch to do this. > > I'm very sorry for the rebase and merge pain, but we think this is worth > doing. > > Thanks, > Jan > > [0] https://bugzilla.mozilla.org/show_bug.cgi?id=1144366 > [1] > https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Declarations > [2] http://www.stroustrup.com/bs_faq2.html#whitespace > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
