On Thu, Oct 16, 2014 at 10:04 AM, Ehsan Akhgari <ehsan.akhg...@gmail.com> wrote: > On 2014-10-16, 2:51 AM, Bobby Holley wrote: >> >> This has irked me before too. An obvious compromise would that the >> backout proceeds, but it must include a test that would have failed on >> CI when the patch was landed. This puts the onus on the owners of the >> broken functionality to make sure that this supposedly-critical >> functionality has basic smoketest coverage, and gives the developer of >> the backed-out patch a way to verify that their code is correct on CI. >> >> Backouts should require tests. > > > I don't think it's reasonable to assume that the person doing the backout > has the time or the expertise to add a test for the broken functionality. > > > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform
I don't think that's what bholley is asking for. The onus should be on the developers of the relevant app/feature/whatever to write a test that catches the regression. - Kyle _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
