On 8/6/14 7:11 AM, Benjamin Smedberg wrote:
Not only that, but it also makes our code correct. There is nothing
to guarantee that one of those destrcutors we're skipping right now
would not have observable side effects passed shutdown. So until
somone comes up with an idea on how to enforce that, we should clear
these on all builds. Please make it so. :-)
I don't understand this sentence, but I strongly oppose automatically
clearing Static*Ptr in the static destructor in any build. In the past
we have had static comptr cause final release of objects after XPCOM
shutdown, which causes crashes due to the component manager or CC or
other infrastructure already being shut down.
Wouldn't that be a bug that should be fixed? Besides fixing leaks,
clearing Static*Ptrs would be the method of uncovering these shutdown bugs.
cp
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
