On 6/2/14, 5:33 PM, Gavin Sharp wrote:
Do either of you have reasoning for that other than "it looks better to me"?
My personal experience is that when I try to write xpcshell tests the amount of time it takes to type the test function names is very noticeable and actively interrupts my thinking about what I actually want to test... I find it much simpler to write mochitests than xpcshell tests for this reason.
I'm quite willing to believe this is not the case for everyone else, of course.
I personally think consistency trumps any personal preferences based on length/concision
Of course given the existence of testharness we're not going to get consistency in mochitest anyway, even with this change.
as long as what we end up with isn't unreasonably long/verbose.
I think what xpcshell has now and what testharness says and what's being proposed (with the "Assert." prefix) are unreasonably long/verbose.
-Boris _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
