On 5/6/14, 1:49 PM, Eddy Bruel wrote:
Strict warnings as errors has been a continuous source of pain for the
devtools team. Substantial areas of our code area currently not strict
warning free.
The reason this leads to problems is that the way the werror flag is
propagated makes no sense: it is a context wide flag, which individual
scripts inherit from the context in which they are first compiled. To
give you an idea how this leads to problems: werror is enabled by
default for the main context in xpcshell tests, but disabled for the
context used to JSMs. As a result, a single line patch like this:
btw, I believe the JS team now uses the term "extra warnings" to
differentiate SpiderMonkey's non-standard "strict warnings"
(javascript.options.strict pref) from ES5's "strict mode".
Does anyone actually want these strict/extra warnings? Can we just
remove this misfeature from SpiderMonkey?
These strict/extra warnings are also enabled in Firefox's debug builds
(javascript.options.strict.debug pref), which can cause Firefox features
to misbehave differently in debug and release builds. Besides the
`obj.quacks || false` problem, it can also report false positive
warnings about some functions' unreachable code paths not returning a value.
chris
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
