Dan, Congratulations on landing the jit-tests split! I'm glad to hear we're getting a make check replacement too. We discussed it a bit in IRC and the rough decision, at least between jorendorff and myself, was to expand the scope of the replacement to run /all/ of SpiderMonkey's test suites.
Ideally we'd like to be able to tell new contributors "Run this and if it passes you're probably good to go." instead of "Why didn't you run this other test suite? What do you mean it's not in the wiki? Oh, you looked at that old page. Well then." This should be as simple as adding |./tests/jstests.py <shell> --tbpl| to mach check-spidermonkey. It sounds like you've got it under control, but please ping me if you want input. Cheers, Terrence On 04/04/2014 05:44 AM, Daniel Minor wrote: > Hi Nicolas, > > This change only affects running the jit-test test suite as part of "make > check". This doesn't affect building or running the JS shell. > > The mach command that has been added replicates how this particular test > suite was previously run in "make check". It could be expanded, of course. > > Thanks, > > Dan > > > > ----- Original Message ----- > From: "Nicolas B. Pierron" <nicolas.b.pier...@mozilla.com> > To: dev-platform@lists.mozilla.org > Sent: Friday, April 4, 2014 8:31:32 AM > Subject: Re: Removing 'jit-tests' from make check > > On 04/04/2014 03:39 AM, Daniel Minor wrote: >> Just a heads up that very soon we'll be removing jit-tests from the "make >> check" target[1]. The tests have been split out into a separate test job on >> TBPL[2] (labelled Jit), have been running on Cedar for several months, and >> have been recently turned on for other trees. We've added a mach command-- >> "mach jittest" that runs the tests with the same arguments that "make check" >> currently does. > > "mach jittest" ? > > Is there any documentation which explain how to only work with the JS Shell > by using mach commands? Does this change implies that every JS developer > will have to compile the full browser just to work on the Shell? > > The only documentation I know [1] explains how to run a configure && make. > > [1] https://developer.mozilla.org/en-US/docs/SpiderMonkey/Build_Documentation > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
