On 2014-03-23, 3:36 PM, xunxun wrote:
Hi,

     I found that in 28.0 and 29.0beta1 JS/src used unified build in its
moz.build ( UNIFIED_SOURCES), but when I build 28.0 and 29.0beta1, I
can't find JS/src modules built using unified method ( Windows+MSVC ),
at the same time, dom/bindings can be built using unified method. I want
to know whether some modules' unified build is disabled in release and
beta, how can I enable it in JS/src ?

We have three sets of source code which we unify upon compilation:

1. Generated WebIDL DOM bindings in objdir/dom/bindings.
2. Generated IPDL protocols in objdir/ipc/ipdl.
3. Unified source code using UNIFIED_SOURCES in moz.build files.

The first two of these are generated source code which means that we can unify them with a high degree of confidence without the fear of unknown bugs creeping in.

For the third category above, we are not confident yet that unifying the source files together is not introducing bugs. Because of this reason, we disable unified builds during the uplift to Aurora (see https://mxr.mozilla.org/mozilla-aurora/search?string=disable-unified-compilation.)

Also note that --disable-unified-compilation only affects #3 above.

Hope that this helps.

Cheers,
Ehsan
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to