-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 02/27/2014 10:26 AM, Zack Weinberg wrote: > Does that mean a patch to squelch the uninitialized variable > warnings in layout will now be accepted? Those are the only > warnings in layout on my (Linux, debug) builds. > >> layout/base/FrameLayerBuilder.cpp:3462:56 >> [-Wmaybe-uninitialized] ?last? may be used uninitialized in this >> function
If there's no perf impact, then probably, for at least some of them! The merits of maybe-uninitialized warning-fixes can vary on a case-by-case basis, because in some cases, it's just a false positive and the only way to "fix" it has a (small) perf cost. (which is why we don't treat it as an error in warnings-as-errors builds) ~Daniel -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTD5YFAAoJEOxXkPfRs1MynHMQAJq45CXlXUUc6yuOcTrFmYi0 DIu0OYAtJZ0G65ZBWNpOOe6SGvCbXzB11L4S2Cdu0EeevHBooZ2JRCZpw5/pl8zc DQoY07mPFUjKejaqj2RtU6peNFF1+QDUgMasoAtuU+bXq/v9wpcCvEq1AV1kskSN H0PNsO5XKwwix65zxYOihwR4lbyjQHcgZ0rD7hIUAYmaGw5YhYQnZo205ltO6vQe ZsruUu3ttJ9Xbujyh1KUbandlAu60bFovPmCNApivrnSPEQnSHiDOyRaSnzVfg11 eJ07ehB2glUnvt5OP+/Kj+Jlnq1GFiwHAV5QbqdEbvcXG3inhfGz7bjPJPhFUqEE YBKlZznxnIxxLYGPYazjY2rVbcBqK5S1LW21A4JlmY5gC65OxgBs4z+eu20/ZSxH YSDcDlCBRcHv5ulTS9pb5rvOB0oN/RNBu0RO2C9ZQwZ33RkkaQbYeIPKd3aLLgAf 0ODUNpiGFeAj8Z0ZxBmVf88M5LgXRG3+nOzWDyeJFcfPvuBTw0dLfYv/Oyq6oipE pG/3R6MsPV6yIgBQVPxISXddt8mc2h6w4GgVG6XReKZ6m0XxKAOOqEjBwx1jYQpe OKjY3MKuptHbN450a4JIJQBFntq6bdREoAJE2qNBhsLNXE1qY3E2D4Q7QGYkLYpe CpP9u2+MI490/om4F1vv =Vhyr -----END PGP SIGNATURE----- _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
