On Tue, Feb 25, 2014 at 12:53:12PM -0800, Nicholas Nethercote wrote: > On Tue, Feb 25, 2014 at 12:48 PM, Ehsan Akhgari <ehsan.akhg...@gmail.com> > wrote: > >> > >> The Valgrind test job does leak checking, and it's recently caught > >> some leaks and caused the offending patches to be backed out. However, > >> the test coverage is pretty meagre, and it's desktop only so can't > >> detect leaks in IPC code. > > > > These leaks are reproducible on desktop, as part of mochitest-2. For > > reproducing them locally, you need to run the tests in dom/browser-element. > > Any idea why they were not caught then? > > Valgrind doesn't run mochitests because it's far too slow. It > currently just runs the PGO profiling code, which is in > build/pgo/index.html. It would be good to increase the coverage -- > separating the Valgrind test code from the PGO profiling code will be > easy -- but we can't do it too much otherwise the job will be too > slow. Currently it typically takes ~45 minutes and ~38 minutes of that > is build time.
I never understood why we need those jobs to be builds. Why not turn --enable-valgrind on m-c builds, and run valgrind as a test job? Mike _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
