Ideally you would have talked to the Toolkit module owner (i.e. me) before adding a new chunk of code to it but Toolkit has basically become the wild-west of modules and I'm not sure what purpose an owner is meant to have at this point. The Submodule page is probably hopelessly out of date at this point and I don't know if trying to save it is the right thing to do.
On Sun, Jan 19, 2014 at 6:47 PM, Shih-Chiang Chien <sch...@mozilla.com>wrote: > I added a component for captive portal detection about a year ago. Should > I update https://wiki.mozilla.org/Toolkit/Submodules myself? > > Best Regards, > Shih-Chiang Chien > Mozilla Taiwan > > On Jan 20, 2014, at 8:17 AM, Tom Schuster <t...@schuster.me> wrote: > > > I refactorted and debugged most of the findbar code. Mike seems to the de > > facto owner, so I think it makes sense for me to do reviews. I doubt > > anybody else knows much about the code. There seems to be no submodule > for > > it anyway? > > On Jan 19, 2014 10:40 PM, "Matthew N." <ma...@mozilla.com> wrote: > > > >> Thanks for clarifying. > >> > >> Myself, Jared Wein, and Paolo Amadini (Download Manager Owner) seem to > be > >> missing from the Toolkit peer list then. > >> > >> Thanks, > >> Matthew > >> > >> On 1/19/14, 8:47 PM, Dave Townsend wrote: > >> > >>> Everyone who is a preferred reviewer should be a peer, if they aren't > it's > >>> likely because I forgot to update the appropriate lists. Who do you see > >>> who > >>> is absent from the peer list? > >>> > >>> > >>> On Sat, Jan 18, 2014 at 11:51 AM, Matthew N. <ma...@mozilla.com> > wrote: > >>> > >>> Hello, > >>>> > >>>> What does it mean to be a "Preferred Reviewer" (previously called a > >>>> "peer") in a Toolkit sub-module[1] and not be on the list of Toolkit > >>>> Peers[2]? The Toolkit Code Review page[3] doesn't seem to cover this > >>>> case. > >>>> > >>>> Specifically: > >>>> 1) Can a "Preferred Reviewer" review code in the related submodule > >>>> without > >>>> oversight from the sub-module owner? > >>>> 2) Is a sub-module "Preferred Reviewer" considered a "Toolkit > reviewer" > >>>> for the purposes of [3]? > >>>> > >>>> Thanks, > >>>> MattN > >>>> > >>>> [1] https://wiki.mozilla.org/Toolkit/Submodules > >>>> [2] https://wiki.mozilla.org/Modules/Toolkit > >>>> [3] https://wiki.mozilla.org/Toolkit/Code_Review > >>>> _______________________________________________ > >>>> dev-platform mailing list > >>>> dev-platform@lists.mozilla.org > >>>> https://lists.mozilla.org/listinfo/dev-platform > >>>> > >>> _______________________________________________ > >> dev-platform mailing list > >> dev-platform@lists.mozilla.org > >> https://lists.mozilla.org/listinfo/dev-platform > >> > > _______________________________________________ > > dev-platform mailing list > > dev-platform@lists.mozilla.org > > https://lists.mozilla.org/listinfo/dev-platform > > > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
