On 1/7/2014, 2:29 PM, Martin Thomson wrote:
On 2014-01-07, at 11:28, Benjamin Smedberg <benja...@smedbergs.us> wrote:

Especially for new contributors we shouldn't assume that most editors can do 
this correctly. I personally think that the risk of introducing a new member 
and then having locals shadow members is real enough that we should somehow 
distinguish them. I don't have strong opinions about our current mFoo naming 
versus the google-like member_ naming.

I have a tool for that: static analysis tools usually have a shadowing 
detection function.

But many people don't have those tools, so this is not a good argument. (Note that we don't even turn on -Wshadow currently)

Cheers,
Ehsan

_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to