On Mon, Dec 02, 2013 at 06:23:00PM -0500, Ehsan Akhgari wrote: > On 12/2/2013, 2:36 PM, Chris Peterson wrote: > >On 11/29/13, 7:39 PM, Mike Hommey wrote: > >>I think it's time, 9 days before the merge, to think about whether we > >>want unified builds to ride the train or not. I'm almost tempted to > >>suggest that we disable unified builds on nightlies, but that would > >>probably hide the problems even more. > > > >I don't think Mike's original question has been discussed in this > >thread: should we disable unified builds for Aurora 28? I think it is a > >good idea because there are still open questions about unified build > >code and stability issues (though Aurora will then hit the non-unified > >build problems right away). > > I discussed this with Mike on IRC last Friday, and have thought > about this a bit more since then, and I believe that we should > disable unified builds on mozilla-aurora and all branches past that > point, perhaps indefinitely. Unified builds don't really buy us > that much for code that gets compiled on those branches anyway, and > if developers want to have them locally then they can always pref it > on in their mozconfigs. > > I filed this as bug 945496. > > >As for identifying broken non-unified builds, can we configure one of > >our mozilla-inbound platforms to be non-unified (like 32-bit Linux Debug)? > > I think the answer to that question depends on how soon bug 942167 > can be fixed. Chris, any ideas?
In the meanwhile, I proposed in bug 945496 that we disable unified builds on all debug builds, until we have something better, because, while I'm running non-unified builds on the birch branch, at 7 days from the merge, the chances of non-unified builds to break are pretty big, especially when you consider three different bugs landed in the past 12 hours that broke them each in their own way. I will land the patch doing this later today or further tomorrow, after I'm sure the tree I'm landing on still builds this way (and I'd rather have that happen on top of a multiple-way fx-team and b2g-inbound merge) Mike _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
