2013/11/20 Gregory Szorc <g...@mozilla.com>

> On Nov 20, 2013, at 9:37, Benoit Jacob <jacob.benoi...@gmail.com> wrote:
>
> > Talking about ideas for further extending the impact of UNIFIED_SOURCES,
> it
> > seems that the biggest limitation at the moment is that sources can't be
> > unified between different moz.build's. Because of that, source
> directories
> > that consist of many small sub-directories do not benefit much from
> > UNIFIED_SOURCES at the moment. I would love to have the ability to
> declare
> > in a moz.build that UNIFIED_SOURCES from here downwards, including
> > subdirectories, are to be unified with each other. Does that sound
> > reasonable?
>
> You can do this today by having a parent moz.build list sources in child
> directories.
>

>From the perspective of someone porting a directory to UNIFIED_SOURCES, and
wanting to make minimal changes at this point to see how much compile time
improvement we can get without making too intrusive changes everywhere,
that is not the same: Switching an entire directory to listing all sources
in the parent moz.build is a very intrusive change to make to the build
system. I've been refraining from doing that for now.

Benoit


>
> Keep in mind some moz.build/Makefile.in still customize directories on a
> directory-by-directory basis.
>
> I would love to see a project that consolidated data into fewer moz.build
> files. The recent work around how libraries are defined should have made
> that easier. But there are still things you can only do once per directory.
> Those limitations will disappear eventually.
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to