On Tue, Nov 19, 2013 at 03:12:23PM +1300, Robert O'Callahan wrote: > Lovely!!! > > On Tue, Nov 19, 2013 at 3:02 PM, Mike Hommey <m...@glandium.org> wrote: > > > - FINAL_LIBRARY defines what library your code is going to be linked > > into. That needs to match an existing LIBRARY_NAME in some other > > moz.build. Most code will go in either xul, gkmedias or gklayout. Note > > gklayout may go away in the future > > > > What about gkmedias? Is there any reason other than Windows linker memory > usage to keep it?
No other reason. So if you want something to go in gkmedias on windows, just declare FINAL_LIBRARY = 'gkmedias'. Important note: You don't need to add a condition and declare FINAL_LIBRARY = 'xul' for the non windows case. Declaring FINAL_LIBRARY = 'gkmedias' works for all builds. FWIW, there's an open bug to fold gkmedias back into xul, but it looks like it's not going to happen soon. https://bugzilla.mozilla.org/show_bug.cgi?id=922912 Final note, I forgot to mention webrtc. Unfortunately, due to how the gyp data is treated currently, webrtc doesn't benefit from this magic, and things still have to be defined in layout/media/webrtc/Makefile.in. That will change in the future, fortunately. Mike _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
