On 08/01/2013 06:50 PM, Nicholas Nethercote wrote:
On Thu, Aug 1, 2013 at 6:29 PM, Gavin Sharp <ga...@gavinsharp.com> wrote:
Do you have specific issues you're worried about, or are you just speaking
about issues in general?
This AdBlock issue worries me specifically.  And the fact that there's
breakage with our #1 add-on makes me worry in general.

Without special support, addons won't see content in the remote thumbnail processes since they don't have access to the DOM there. We have been working on making Adblock and other addons work in other processes, but the code isn't ready to ship.

In general, I don't see us resolving e10s issues until we have some
incentive to do so, and get some sense of their relative severity.
Huh?  This sentence seems entirely antithetical to our standard
operating procedure.  I.e. backing out known regressions, etc.

As far as I know, the only strict backout policy we have is for performance regressions on certain commonly accepted benchmarks. It would be impractical to backout any change that causes a regression in anything.

I think decisions about the thumbnail code should be made on the merits of that code alone. Personally I think that the benefits of generating the thumbnails off the main thread outweigh the loss of ad blocking in the thumbnails.

-Bill

_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to