On 7/05/2013 11:49 PM, Mike de Boer wrote:
TLDR; in bug 867742 I requested to adopt two JS modules, Async.jsm
and AsyncTest.jsm, in mozilla-central/toolkit/modules. The whole
story can be read below as well as at
https://gist.github.com/mikedeboer/5495405. I posted about this
subject before on firefox-dev:
https://mail.mozilla.org/pipermail/firefox-dev/2013-April/thread.html#268
I don't see the advantage to this, even after re-reading that thread.
It seems like the biggest advantage is that it addresses *your* aversion
to using promises while ignoring the fact that promises and Task.jsm are
being used fairly extensively in our tests (and more and more in the
production code). To my mind, this alone makes your claim:
| most of the unit tests are written in the same structure and b) are
| structured in such a way that they're easy to read by someone other
| than you.
somewhat suspect - unless you are also proposing to remove promises from
the existing tests? Combine this with the non-obvious features such as
magic prefixes for the test descriptions and I'm concerned this would
make the cognitive overhead of understanding our tests worse rather than
better.
While I appreciate the sentiment and would always encourage discussions
which aim to make things better, I see more potential downsides than
upsides in this proposal.
Just-my-2c ly,
Mark
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
