Hi Anthony, thanks for bringing this up. I completely agree that we have to unify all that scrolling code. Chris Jones and Doug Sherk wrote most of the current C++ async scrolling code. We should definitely unify around that. Once we support multiple concurrent scrollable regions instead of just one level of scrolling, BrowserElementScrolling.js won't be needed anymore I think. The Java code should definitely die. Since you have worked a bunch on this code, I don't think anyone would try to stop you if you want to propose a plan and I am sure Chris is happy to help draft it.
Andreas On Jan 28, 2013, at 8:14 PM, Anthony Jones <ajo...@mozilla.com> wrote: > I've spent several weeks fixing scrolling and zooming bugs on b2g. You > may have enjoyed bug 831973 (and it's duplicates) over the last week. In > bug 811950 it took -9 lines to introduce the bug and a further -27 lines > to fix it. Perhaps we have too much scrolling code: > > * AsyncPanZoomController.cpp > * BrowserElementScrolling.js > * PanZoomController.java > * nsFrameLoader.cpp > > There is a fair amount of duplication here. Ideally we should have a > single async implementation with a good set of tests. Removing the > duplication is going to require some collaboration. > > Are there other scrolling implementations that I've missed? > > Who is responsible for each of these implementations? > > What will it take to get to a single implementation? > > Anthony > > > > > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
