Hello everyone!

A summary of the situation:

1. bug 824016 was a known intermittent failure that we believe we fixed in m-c with bug 827083. I did some important changes to how the web console initializes / destroys - changes that we hope allow us to better ensure in our tests that we listen for the correct initialization/destroy event.

2. bug 824016 seemed to be a failure caused by a timeout of 5 seconds - waiting to open 4 web console instances, in 2 tabs (in 2 windows). On slow machines 5s may not be enough. The new toolbox we landed has slowed initialization a bit, in the early landing. However, our team has been working on improving the performance.

3. In the m-c patch for bug 827083 we've increased the test timeout, along with the web console initialization/destroy changes.

4. For aurora I did a minimal patch that fixes only bug 827083 - I did not increase the timeout for the multiple_windows web console test. (as usual, for aurora/beta we try to keep patches minimal, with no unrelated changes). I did not expect this test to cause so much trouble in aurora. My bad here!

5. Today I've been notified of the situation and together with Panos we've landed 3 test fixes. For the two failing web console tests I've attempted to pick a better event to listen for the web console destroy. It seems to me the two tests finish() too early, before all console/toolbox cleanups complete, hence the memleaks. I also tried to increase the timeout for the multiple_windows test.

6. The above attempt did not prove successful. Together with Ehsan and Panos we decided to disable the two web console tests. Reasoning: this is almost certainly a tests issue, not a problem with how the toolbox cleans-up after itself. For us to actually fix the memleaks in the two tests we would have to land the big patch from bug 827083 and potentially other toolbox fixes that may have improved the situation. This is, if I am not mistaken, too much m-c backporting into aurora - would require approvals and might be much riskier than disabling the tests.


At this point I hope aurora reopens ASAP. Apologies for the trouble. Thank you!


Best regards,
Mihai
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to