On 1/15/13 1:11 PM, Ehsan Akhgari wrote:
Hi all,
Currently, DONTBUILD only takes affect if it's set on the tip of the
changesets that you push. This can cause problems when merging between
different trees if the target tree is a full subset of the origin tree
(i.e., fast-forward merges in git terminology) when the top-most changeset
is DONTBUILD, since it means that the entire push will not get builds and
tests.
Over in bug 815215, I've proposed that we change DONTBUILD to have
per-changeset semantics, meaning that for each patch that does not require
builds and tests, you should add DONTBUILD to your commit message. With
this change, buildbot will look at all changesets in your push and will
only skip builds if all of them are DONTBUILD.
What this means to you as a person who merges trees is that you'll get sane
semantics by default. If you're a person who writes DONTBUILD changes,
this means that you should now specify it on all individual patches (which
in practice only makes a difference if you push more than one DONTBUILD
changeset at a time to let's say inbound.)
This seems to make sense. My only concern is if there is a scenario
where you absolutely need to push without incurring a build (think merge
commit where you don't have control over the previous commits). I'm not
sure why we'd do that, so I'm inclined to believe that such a scenario
does not exist.
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
