On Mon, Dec 3, 2012 at 11:32 AM, Norbert Lindenberg < mozillali...@lindenbergsoftware.com> wrote:
> As part of implementing the ECMAScript Internationalization API [1, 2] in > SpiderMonkey, and as an aid in internationalizing other functionality in > Mozilla products [3], I need to integrate the ICU library (International > Components for Unicode [4]) into the source tree and the build. > > For integrating ICU into the source tree, I see two main alternatives: > > - Add the required set of ICU source files as separate files to the > Mozilla repository. The current version of ICU (50.1, C/C++ version) has > about 5350 source files; stripping out files that aren't needed for the > internationalization API (but might be needed later) brings this to about > 3250 files. The complete Mozilla tree before this addition has about 70,000 > files. > > - Add the source bundles (zip/tar) to the Mozilla repository, and then > extract the source files as part of the build. > > One might also imagine leaving ICU out of the tree entirely, and either > downloading the sources as part of the build, or building ICU completely > separately and only installing the binaries, but neither of these options > seem appropriate. > > Comments? > > Thanks, > Norbert > > [1] > http://wiki.ecmascript.org/doku.php?id=globalization:specification_drafts > [2] > http://norbertlindenberg.com/2012/10/ecmascript-internationalization-api/index.html > [3] https://bugzilla.mozilla.org/show_bug.cgi?id=724529 > [4] http://site.icu-project.org > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > We should just add the ICU sources to the tree. The complexity of extracting/downloading the sources during the build would be high, and we don't do that for any other third-party library. I'm far more worried about ICU's impacts on the size of the binaries we ship to users than I am about the impact to the size of our source tree ;-) - Kyle _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
