I've looked a bit deeper into the code, and there's unused functionality that I'd like to rip out of JarMaker.py in favor of this:

Support for multiple jars in one go is one thing I'd love to axe. I've probably added that thinking we could one day just fire one jarmaker for all of a language pack, but that doesn't need to be in jarmaker itself, if we'd ever do that.

I'm tempted to drop support for processing stdin, too.

Much of that was there to be backwards compat, but these days we only have two entry points into JarMaker, both passing in a single file on disk (rules.mk and mobile's custom built search-jar).

Ted?

I'd hack on that, fwiw, and I'd do so quickly, as we'll want this in 18 for b2g :-/

Axel

On 01.10.12 21:13, Axel Hecht wrote:
Hi,

for both android and b2g, we end up only needing a handful of localized
files from toolkit.

I propose to extend JarMaker.py and jar.mn to support something like a
fake relativesrcdir, say

@relativesrcdir toolkit/locales

and then the following lines would pick up files from toolkit/locales
instead of b2g/locales or mobile/android/locales.

Does that sound sane to folks?

Axel

Bugs affected:
android, https://bugzilla.mozilla.org/show_bug.cgi?id=792077
b2g, https://bugzilla.mozilla.org/show_bug.cgi?id=796051

_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to