[ http://jira.magnolia.info/browse/MAGNOLIA-2427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18620#action_18620 ]
Philippe Marschall commented on MAGNOLIA-2427: ---------------------------------------------- Ok, here we go again. Some notes: # The thread pool has an unbounded job queue. Maybe it would make sense to limit it to something like 500 so that jobs can't be produced too fast. # The thread pool lazily allocates 10 Threads that don't time out. Maybe it would make sense to tweak that as well and have at minimum one thread and at most 10. # If for some reason (like the current thread being interrupted) a job can't be added to the pool an Exchange exception is thrown. > replace custom thread pool with library > --------------------------------------- > > Key: MAGNOLIA-2427 > URL: http://jira.magnolia.info/browse/MAGNOLIA-2427 > Project: Magnolia > Issue Type: Improvement > Components: activation > Affects Versions: 3.6.3 > Reporter: Philippe Marschall > Assignee: Philipp Bracher > Priority: Minor > Attachments: ThreadPool.EDU.oswego.patch, ThreadPool.java.patch > > > The module exchange-simple uses it's own thread pool instead of a library. > There is no need for this since there are mature, stable, tested and debugged > libraries available that do this. The attached patch uses the backport of > java.util.concurrent that as an easy migration path to JDK 1.5 in Magnlia 4. > The patch also removes two unused variables and corrects some indentation > issues. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia.info/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ---------------------------------------------------------------- for list details see http://documentation.magnolia.info/ ----------------------------------------------------------------