[ http://jira.magnolia.info/browse/MAGNOLIA-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18466#action_18466 ]
Gregory Joseph commented on MAGNOLIA-1479: ------------------------------------------ I like the AbstractRenderer / Renderable approach, but something bothers me about exception handling: haven't been able to pinpoint it exactly, but previously when a paragraph template had a syntax error, it was appear onscreen in this infamous ugly yellow background. Not cool in production but very useful while working on templates. Now all i get on screen is a RenderException from the page template, wrapping the paragraph's RenderException, but the actual freemarker error message is swallowed and only visible in the logs when scrolling furiously. > Refactor Pages/ParagraphRenderer/TemplateRenderer > ------------------------------------------------- > > Key: MAGNOLIA-1479 > URL: http://jira.magnolia.info/browse/MAGNOLIA-1479 > Project: Magnolia > Issue Type: Improvement > Components: templating > Reporter: Gregory Joseph > Assignee: Philipp Bracher > Fix For: 3.7 > > > There is certainly room for improvement and removal of duplicate stuff. > TemplateRenderer and ParagraphRenderer could be one single thing. Maybe Pages > too. > Maybe Paragraph, Template and Pages would implement a common "Renderable" > interface, for instance. > As Philipp mentionned, pages already have support for: > - multiple actions > - usage of commands > - setting request parameters > - simple template selection based on resolved view name -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia.info/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ---------------------------------------------------------------- for list details see http://documentation.magnolia.info/ ----------------------------------------------------------------