[ http://jira.magnolia.info/browse/MAGNOLIA-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18398#action_18398 ]
Jan Haderka commented on MAGNOLIA-1482: --------------------------------------- How do you think it should work? There is no {{setServletContext()}} method on {{WebappContextTemplateLoader}} would it be safe to assume servlet context never changes and cache instance of the WCTL with the SC as it was when loaded first time? This might not work when server decides to temporarily increase number of instances of default servlet due to load and discard them later. > Templates stored in repository > ------------------------------ > > Key: MAGNOLIA-1482 > URL: http://jira.magnolia.info/browse/MAGNOLIA-1482 > Project: Magnolia > Issue Type: New Feature > Components: templating > Reporter: Gregory Joseph > Assignee: Jan Haderka > > At the moment, templates (ie. paragraph or pages) are stored on the > filesystem (jsp) or the classpath (freemarker) > Having them on the repo (a specific workspace) would allow > * activating them (no more manual files copying) > * editing them within Magnolia > This seems pretty easy to implement for freemarker templates (implement a new > freemarker.cache.TemplateLoader), with one warning though: since freemarker > caches the result of its template parsing, loading the templates should > probably occur in an acl-unaware way, i.e we should not try to restrict > who/what can render certain templates. (of course, it's a different story for > editing them through the admin interface, where we definitely want to use > ACLs to determine who can view the templates source and modify them) > Doing the same thing for JSPs seems rather cumbersome (one could imagine > writing the repo content to the filesystem on creation/activation of node), > and I'm not sure we should encourage this. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.magnolia.info/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ---------------------------------------------------------------- for list details see http://documentation.magnolia.info/ ----------------------------------------------------------------