On May 2, 2007, at 10:26 , Sameer Charles wrote:

So, any objection if I bring back the logout filter? :)

Fine with me too; now looking at the code, I see the LogoutPage does "more" than the filter was doing (closing the JCR sessions). Should we completely get rid of the page, and/or move that code away to Authenticator for instance ?

While on the subject, I was just discussing with Sameer: we could probly have a LoginFilter (or a LoginLogoutFilter) to replace (or delegate to) the Authenticator class, thus hiding the http/html  crust out of Authenticator, and out of ContentSecurityFilter and URISecurityFilter; making the authentication mechanism potentially more replaceable (could be useful for integration with existing apps)

g


On May 2, 2007, at 10:22 AM, Fabrizio Giustina wrote:

Hi Sameer,

On 5/2/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
Revision 9277 Author scharles Date 2007-05-02 10:03:01 +0200 (Wed, 02 May
2007)
Log Message - Logout is handled by logout page

Removed Paths
magnolia/trunk/magnolia-core/src/main/java/info/magnolia/cms/ security/LogoutFilter.java

Using a filter for logout is definitively a better solution than using
the logout page, and this can be required in some cases: for example
if you need to login/logout the user without changing the current page (when the page is not protected, but its content can be different when
the user is logged) you can't use the logout page...
So, any objection if I bring back the logout filter? :)

fabrizio

----------------------------------------------------------------
for list details see
http://www.magnolia.info/en/developer.html
----------------------------------------------------------------

Regards,

Sameer Charles
Magnolia International Ltd.

---------------------------------------------------------------------- -----------
[EMAIL PROTECTED]       http://www.magnolia.info
Magnolia®  - Simple Enterprise Content Management
---------------------------------------------------------------------- -----------







----------------------------------------------------------------
for list details see
http://www.magnolia.info/en/developer.html
----------------------------------------------------------------


----------------------------------------------------------------
for list details see
http://www.magnolia.info/en/developer.html
----------------------------------------------------------------

Reply via email to