Fwiw, I have two somewhat conflicting thoughts related to this: 1. The email service needs to grow rate-limiting soon and if there's a standalone service available to use already, that will probably save me some time.
2. Historically I've found the customs server code hard to grok. Part of me dreads the prospect of working with it again. Of course, extracting it into its own service might also involve improving readability/maintainability, which would abate my dread. But if a 3rd-party option can do the same job (I haven't dug into the ratelimit/limitd links yet), I might be more inclined to take that option. On Thu, Sep 20, 2018 at 6:11 AM, Julien Vehent <[email protected]> wrote: > +alm & g-k > > On Thu, Sep 20, 2018, 00:52 Ryan Kelly <[email protected]> wrote: > >> On Thu, 20 Sep 2018 at 14:35, Ryan Kelly <[email protected]> wrote: >> >>> >>> Hi All, >>> >>> Over in github we've been discussing our options of rate-limiting >>> pairing channel creation attempts: >>> >>> https://github.com/mozilla-services/channelserver/issues/21 >>> >>> One obvious approach would be to use the existing fxa-customs-server, >>> and just add some new action types like "createPairingChannel" and >>> "connetToPairingChannel" that the channelserver can send over for >>> checking. However, the fxa-customs-server is currently run as a private >>> "sidecar" service for fxa-auth-server, exposed only over a localhost >>> interface. >>> >>> Does it make sense for us to try to extract fxa-customs-server into its >>> own standalone service that can be accessed by multiple consumers? Or is >>> that likely to be more work than just adding rate-limiting code directly >>> into the channelserver? >>> >> >> Another option would be to try running a third-party ratelimiting daemon >> that can be shared among different services, such as: >> >> https://github.com/lyft/ratelimit >> https://github.com/limitd/limitd >> >> Which may be less work than adding custom rate-limiting code in >> channelserver. >> >> +ulfr for possible opinions from opsec team. >> >> Cheers, >> >> Ryan >> > > _______________________________________________ > Dev-fxacct mailing list > [email protected] > https://mail.mozilla.org/listinfo/dev-fxacct > >
_______________________________________________ Dev-fxacct mailing list [email protected] https://mail.mozilla.org/listinfo/dev-fxacct
