Hi Shane,

The dashboard that makes use of this info is:
https://kibana.fxa.us-west-2.prod.mozaws.net/#/dashboard/elasticsearch/Client Snippet

I've put together a couple of one-off reports; I don't think any one else is looking at it regularly. We can change the format if need be.

That said, your proposal causes some problems, as nested json is harder to consume in any of our tools -- the json blob needs special case code to be parsed (heka) or is basically inaccessible (kibana3). (Datadog and kibana4 probably fall somewhere in the middle: possible but painful).

Suggestion: log a more compact, easy-to-parse-in-tools format. Don't include the url: it is not needed for stats and the id/url mapping can be managed elsewhere.
...
  marketing: [android-sync:false,hello:true]
...

cc'ing trink, as he may have a different take.

Cheers,
Katie

On 4/22/15 1:27 PM, Shane Tomlinson wrote:
Hey Katie (& list),
I am helping Jon Petto from the growth team integrate a new verification
page snippet into the content server. Unlike our previous marketing
snippet, the new snippet has two links instead of just one. I'd like to
log metrics on each of these links. Our current schema [1] only allows a
single marketing link to be logged, which is unfortunate.

I want to change the format [2]. Are the `marketingLink`,
`marketingType`, and `marketingClicked` fields consumed by anybody? If
not, this will be easy. If so, it bit trickier.

I propose to log something like the following snippet as part of the
metrics that are sent to the /metrics endpoint:

...
marketing: [
   {
     id: 'android-sync',
     url: 'https://play.google.com/somebiglongscarylink',
     clicked: false
   },
   {
      id: 'hello',
      url: 'https://hello.firefox.com',
      clicked: true
   }
],
...

This would give us the ability to log an arbitrary number of marketing
items, potentially across multiple screens.

What do you think?

Shane

--------------------

[1] -
https://github.com/mozilla/fxa-content-server/blob/master/app/scripts/lib/metrics.js#L40-L42
[2] - https://github.com/mozilla/fxa-content-server/issues/2338
_______________________________________________
Dev-fxacct mailing list
[email protected]
https://mail.mozilla.org/listinfo/dev-fxacct

Reply via email to