Important question... Did we get a chance to report this to email on acid yet? Followup, can we use health and wellness credits to get a litmus account?
Side note, you're awesome (rfeeley is "OK" too). Considering all the bugs i've missed and should have caught much earlier, this isnt a huge issue. #mozlove Oh, and congrats on the release everybody! [insert gif here] > On Apr 29, 2014, at 7:33 AM, jgruen <[email protected]> wrote: > > If you’ve had a chance to look at the bug, it’s pretty clear where the > error’s coming from. I used an MSO conditional in the email templates to > render our button in Outlook clients and forgot to add the template link into > an href attribute. Two things: > > [1] I’m sorry for the oversight. It’s no fun to be the guy who made the PR > responsible for this one. > > [2] It’s worth mentioning that the email test suite I used (Email On Acid) > didn’t catch the bad href in the link maps it generated from the email > templates. There’s that aphorism about poor craftsmen blaming their tools, > but still. If FxA is going to generate potentially millions of emails over > the coming year, it seems prudent to consider a more robust email testing > solution going forward. > > >> On Apr 29, 2014, at 10:06 AM, Peter deHaan <[email protected]> wrote: >> >> Unpopular suggestion: should we include the full link as text under the >> button as a fallback? >> >> It'd be long and cluttered, but users would always be able to >> select-copy-paste into a browser. > > Probably less unpopular now than it was 12 hrs ago. There are ways to do this > that won’t look insane. > >> >>> On Apr 29, 2014, at 7:02 AM, Shane Tomlinson <[email protected]> wrote: >>> >>> Good morning everyone! Firefox 29 is out in the wild, and an issue was >>> uncovered that may require another prod push. >>> >>> Start with Bugzilla #1003082 [1]. The email verification link is broken in >>> Outlook. More precisely, the link displayed to the user is "http://";. >>> >>> Ryan Kelly quickly issued a content-server PR [2] to correct the error in >>> the email verification templates. >>> >>> Tests pass locally, but not on travis. Manual testing, including in >>> Outlook, needed. > > Travis passing now. > >>> >>> Shane >>> >>> ================= >>> >>> [1] - https://bugzilla.mozilla.org/show_bug.cgi?id=1003082 >>> [2] - https://github.com/mozilla/fxa-content-server/pull/1028 > _______________________________________________ Dev-fxacct mailing list [email protected] https://mail.mozilla.org/listinfo/dev-fxacct
