The branch main has been updated by imp:

URL: 
https://cgit.FreeBSD.org/src/commit/?id=a8b0208e7e989c0876f73e1953f66542678b9004

commit a8b0208e7e989c0876f73e1953f66542678b9004
Author:     Warner Losh <[email protected]>
AuthorDate: 2025-12-04 04:05:06 +0000
Commit:     Warner Losh <[email protected]>
CommitDate: 2025-12-04 06:04:34 +0000

    nvme: Fix devd logging of SMART_ERROR
    
    Remove extra arg so that we have type=SMART_ERROR rather than an invalid
    message. Also log all aens.
    
    Sponsored by:           Netflix
---
 sys/dev/nvme/nvme_ctrlr.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/sys/dev/nvme/nvme_ctrlr.c b/sys/dev/nvme/nvme_ctrlr.c
index 1ad4735cbef8..55b6d6b745cf 100644
--- a/sys/dev/nvme/nvme_ctrlr.c
+++ b/sys/dev/nvme/nvme_ctrlr.c
@@ -677,7 +677,7 @@ nvme_ctrlr_log_critical_warnings(struct nvme_controller 
*ctrlr,
                nvme_printf(ctrlr, "SMART WARNING: unknown critical warning(s): 
state = 0x%02x\n",
                    state & NVME_CRIT_WARN_ST_RESERVED_MASK);
 
-       nvme_ctrlr_devctl(ctrlr, "critical", "SMART_ERROR", "state=0x%02x", 
state);
+       nvme_ctrlr_devctl(ctrlr, "SMART_ERROR", "state=0x%02x", state);
 }
 
 static void
@@ -1143,6 +1143,10 @@ nvme_ctrlr_aer_task(void *arg, int pending)
                goto out;
        }
 
+       nvme_ctrlr_devctl(ctrlr, "aen", "type=0x%x info=0x%x page=0x%x",
+           NVMEV(NVME_ASYNC_EVENT_TYPE, aer->cpl.cdw0),
+           NVMEV(NVME_ASYNC_EVENT_INFO, aer->cpl.cdw0), aer->log_page_id);
+
        aer->log_page_size = 0;
        len = nvme_ctrlr_get_log_page_size(aer->ctrlr, aer->log_page_id);
        nvme_ctrlr_cmd_get_log_page(aer->ctrlr, aer->log_page_id,

Reply via email to