On 2025-08-08 15:59:45 (+0000), Dag-Erling Smørgrav wrote:
The branch main has been updated by des:

URL: 
https://cgit.FreeBSD.org/src/commit/?id=6dab48b9de6c1bff61b0ce78029c1e3cba20895a

commit 6dab48b9de6c1bff61b0ce78029c1e3cba20895a
Author:     Dag-Erling Smørgrav <d...@freebsd.org>
AuthorDate: 2025-08-08 15:57:31 +0000
Commit:     Dag-Erling Smørgrav <d...@freebsd.org>
CommitDate: 2025-08-08 15:57:31 +0000

   build: Switch CLEAN back on by default

   There have been too many issues with non-META_MODE incremental builds
   recently, and it is clear that most users, even developers, were not
   aware that the default had been switched.

   This will be revisited once more work has been done to help prevent
   future breakage.

   This reverts commit ba373fca78a114768244d6a8c27983da870c1169.

   Reviewed by:    markj, jhb
   Differential Revision:  https://reviews.freebsd.org/D51828

Thank you!

Maybe we should just flip CLEAN on for a couple of days/weeks when there's something disruptive on main that benefits from thorough cleaning, but have it off by default?

As I understand it, doing pkgbase builds with CLEAN rebuilds all packages, and pkg will want to update them even if the binaries within are unchanged. We set WITHOUT_CLEAN=1 in the cluster pkgbase builder to try to make sure that doesn't happen.

I would love to put that flag under developers' control so pkgbase package production doesn't stall when a WITH_CLEAN=1 build is needed.

Philip

--
Philip Paeps
Senior Reality Engineer
Alternative Enterprises

Reply via email to