git: 7507d6ca0e75 - main - vmm: Clean up legacy create/destroy interface

[Ed Maste]

The branch main has been updated by emaste:

URL: 
https://cgit.FreeBSD.org/src/commit/?id=7507d6ca0e754b2bb9354b54b3a20f73cfe1f06a

commit 7507d6ca0e754b2bb9354b54b3a20f73cfe1f06a
Author:     Ed Maste <ema...@freebsd.org>
AuthorDate: 2025-07-26 22:51:06 +0000
Commit:     Ed Maste <ema...@freebsd.org>
CommitDate: 2025-07-26 22:51:37 +0000

    vmm: Clean up legacy create/destroy interface
    
    Add sysctl descriptions, and remove surprising default text.
    
    PR:             288437
    Reviewed by:    jhb, markj
    Sponsored by:   The FreeBSD Foundation
    Differential Revision: https://reviews.freebsd.org/D51533
---
 sys/dev/vmm/vmm_dev.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/sys/dev/vmm/vmm_dev.c b/sys/dev/vmm/vmm_dev.c
index 819debadd1ac..2e2ae0a162d8 100644
--- a/sys/dev/vmm/vmm_dev.c
+++ b/sys/dev/vmm/vmm_dev.c
@@ -820,7 +820,6 @@ sysctl_vmm_destroy(SYSCTL_HANDLER_ARGS)
 
        buflen = VM_MAX_NAMELEN + 1;
        buf = malloc(buflen, M_VMMDEV, M_WAITOK | M_ZERO);
-       strlcpy(buf, "beavis", buflen);
        error = sysctl_handle_string(oidp, buf, buflen, req);
        if (error == 0 && req->newptr != NULL)
                error = vmmdev_lookup_and_destroy(buf, req->td->td_ucred);
@@ -830,7 +829,7 @@ sysctl_vmm_destroy(SYSCTL_HANDLER_ARGS)
 SYSCTL_PROC(_hw_vmm, OID_AUTO, destroy,
     CTLTYPE_STRING | CTLFLAG_RW | CTLFLAG_PRISON | CTLFLAG_MPSAFE,
     NULL, 0, sysctl_vmm_destroy, "A",
-    NULL);
+    "Destroy a vmm(4) instance (legacy interface)");
 
 static struct cdevsw vmmdevsw = {
        .d_name         = "vmmdev",
@@ -909,7 +908,6 @@ sysctl_vmm_create(SYSCTL_HANDLER_ARGS)
 
        buflen = VM_MAX_NAMELEN + 1;
        buf = malloc(buflen, M_VMMDEV, M_WAITOK | M_ZERO);
-       strlcpy(buf, "beavis", buflen);
        error = sysctl_handle_string(oidp, buf, buflen, req);
        if (error == 0 && req->newptr != NULL)
                error = vmmdev_create(buf, req->td->td_ucred);
@@ -919,7 +917,7 @@ sysctl_vmm_create(SYSCTL_HANDLER_ARGS)
 SYSCTL_PROC(_hw_vmm, OID_AUTO, create,
     CTLTYPE_STRING | CTLFLAG_RW | CTLFLAG_PRISON | CTLFLAG_MPSAFE,
     NULL, 0, sysctl_vmm_create, "A",
-    NULL);
+    "Create a vmm(4) instance (legacy interface)");
 
 static int
 vmmctl_open(struct cdev *cdev, int flags, int fmt, struct thread *td)