On Fri, Jun 27, 2025 at 08:56:23PM +0200, Baptiste Daroussin wrote: B> On Wed 18 Jun 10:13, Mark Johnston wrote: B> > On Thu, Jun 12, 2025 at 06:20:26PM +0000, Hiroki Sato wrote: B> > > The branch main has been updated by hrs: B> > > B> > > URL: https://cgit.FreeBSD.org/src/commit/?id=4deb9760a9d84d5861ee45162ffebe83f13503b8 B> > > B> > > commit 4deb9760a9d84d5861ee45162ffebe83f13503b8 B> > > Author: Hiroki Sato <h...@freebsd.org> B> > > AuthorDate: 2025-06-12 18:19:32 +0000 B> > > Commit: Hiroki Sato <h...@freebsd.org> B> > > CommitDate: 2025-06-12 18:19:32 +0000 B> > > B> > > rc: Disable pathname expansion when calling run_rc_command() B> > > B> > > Variables for command-line options like $foo_flags can contain characters B> > > that perform pathname expansions, such as '[', ']', and '*'. They were B> > > passed without escaping, and the matched entries in the working directory B> > > affected the command-line options. This change turns off the expansion B> > > when run_rc_command() is called. B> > > B> > > While this changes the current behavior, an invocation of a service B> > > program should not depend on entries in the working directory. B> > B> > This also turns off globbing for /etc/rc.local, which broke one of my B> > scripts. Was that intentional? If so, we should really document it in B> > RELNOTES at the very least. B> B> This broke nuageinit which rely on globbing to in nuageinit_start, that this B> change also broke. B> B> So many downstream CI are now broken, due to this change.
Given that Hiroki is not reacting on this email thread neither in https://reviews.freebsd.org/D51043, I would like to revert this change. I'd like also remind that the problem was discovered during the stabweek testing. Although we thawed the freeze, but we are still working on a good known stable revision for June. Any objections? Adding srcmgr@ -- Gleb Smirnoff
