The branch main has been updated by kp:

URL: 
https://cgit.FreeBSD.org/src/commit/?id=8a85584785e3135f00a6d42e642f0e7ccee4f0f5

commit 8a85584785e3135f00a6d42e642f0e7ccee4f0f5
Author:     Kristof Provost <k...@freebsd.org>
AuthorDate: 2025-02-26 16:22:25 +0000
Commit:     Kristof Provost <k...@freebsd.org>
CommitDate: 2025-02-26 22:40:40 +0000

    pf: fix incorrect calls to pf_translate_icmp_af()
    
    The 'iih' argument is already a pointer, pass it as is rather than its 
address.
    
    Sponsored by:   Rubicon Communications, LLC ("Netgate")
---
 sys/netpfil/pf/pf.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys/netpfil/pf/pf.c b/sys/netpfil/pf/pf.c
index f3c9ea7a2fb1..24ddf75936de 100644
--- a/sys/netpfil/pf/pf.c
+++ b/sys/netpfil/pf/pf.c
@@ -8353,7 +8353,7 @@ pf_test_state_icmp(struct pf_kstate **state, struct 
pf_pdesc *pd,
                                            nk->af))
                                                return (PF_DROP);
                                        pd->proto = IPPROTO_ICMPV6;
-                                       if (pf_translate_icmp_af(nk->af, &iih))
+                                       if (pf_translate_icmp_af(nk->af, iih))
                                                return (PF_DROP);
                                        if (virtual_type == htons(ICMP_ECHO) &&
                                            nk->port[iidx] != iih->icmp_id)
@@ -8465,7 +8465,7 @@ pf_test_state_icmp(struct pf_kstate **state, struct 
pf_pdesc *pd,
                                            nk->af))
                                                return (PF_DROP);
                                        pd->proto = IPPROTO_ICMP;
-                                       if (pf_translate_icmp_af(nk->af, &iih))
+                                       if (pf_translate_icmp_af(nk->af, iih))
                                                return (PF_DROP);
                                        if (virtual_type ==
                                            htons(ICMP6_ECHO_REQUEST) &&

Reply via email to