> On 26. Feb 2025, at 03:23, Bjoern A. Zeeb <b...@freebsd.org> wrote: > > On Tue, 25 Feb 2025, Michael Tuexen wrote: > >> The branch main has been updated by tuexen: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=0e58542fd246242bc64bd03d8b2f28cf981c062b >> >> commit 0e58542fd246242bc64bd03d8b2f28cf981c062b >> Author: Peter Lei <peter...@netflix.com> >> AuthorDate: 2025-02-25 20:37:48 +0000 >> Commit: Michael Tuexen <tue...@freebsd.org> >> CommitDate: 2025-02-25 20:37:48 +0000 >> >> tcp: remove unused field from struct tcpcb >> >> Reviewed by: tuexen >> Sponsored by: Netflix, Inc. >> --- >> sys/netinet/tcp_var.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/sys/netinet/tcp_var.h b/sys/netinet/tcp_var.h >> index e65e44840bd8..31663ed48f81 100644 >> --- a/sys/netinet/tcp_var.h >> +++ b/sys/netinet/tcp_var.h >> @@ -452,7 +452,6 @@ struct tcpcb { >> tcp_seq gput_seq; /* Outbound measurement seq */ >> tcp_seq gput_ack; /* Inbound measurement ack */ >> int32_t t_stats_gput_prev; /* XXXLAS: Prev gput measurement */ >> - uint32_t t_maxpeakrate; /* max peak rate set by user, bytes/s */ > > Is the tcpcb no longer KBI relevant these days? > In the old days we'd simply make this a spare and not move all offsets > below around. I can do that, if it is preferred. I was actually thinking about this, but did not find any variable in the struct which indicates it is unused, spare or so. I do know that the size of the structure matters (smaller is better). So please let me know. I will not MFC this change.
Best regards Michael > >> uint32_t t_sndtlppack; /* tail loss probe packets sent */ >> uint64_t t_sndtlpbyte; /* total tail loss probe bytes sent */ >> uint64_t t_sndbytes; /* total bytes sent */ >> > > -- > Bjoern A. Zeeb r15:7
