On Wed, 13 Dec 2023, Jean-SébastienPédron wrote:

The branch main has been updated by dumbbell:

URL: 
https://cgit.FreeBSD.org/src/commit/?id=509707e8b6b7326c7f4793b6e291f0a8e6939412

commit 509707e8b6b7326c7f4793b6e291f0a8e6939412
Author:     Jean-Sébastien Pédron <dumbb...@freebsd.org>
AuthorDate: 2023-12-08 21:54:29 +0000
Commit:     Jean-Sébastien Pédron <dumbb...@freebsd.org>
CommitDate: 2023-12-13 18:18:46 +0000

   linuxkpi: Add `sysfs_create_link()` in <linux/sysfs.h>

   [Why]
   The amdgpu DRM driver started to use it in Linux 5.18.

   [How]
   The function is a no-op as I'm not sure how to implement this with
   sysctls yet.

   Reviewed by:    manu
   Approved by:    manu
   Differential Revision:  https://reviews.freebsd.org/D43022
---
sys/compat/linuxkpi/common/include/linux/sysfs.h | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/sys/compat/linuxkpi/common/include/linux/sysfs.h 
b/sys/compat/linuxkpi/common/include/linux/sysfs.h
index 3dc1a18fdbd3..8b4160453a3a 100644
--- a/sys/compat/linuxkpi/common/include/linux/sysfs.h
+++ b/sys/compat/linuxkpi/common/include/linux/sysfs.h
@@ -152,6 +152,15 @@ sysfs_remove_file(struct kobject *kobj, const struct 
attribute *attr)
                sysctl_remove_name(kobj->oidp, attr->name, 1, 1);
}

+static inline int
+sysfs_create_link(struct kobject *kobj __unused,
+    struct kobject *target __unused, const char *name __unused)
+{
+       /* TODO */

We've started to add these as
        pr_debug("%s: TODO\n", __func__);

as that way they will at least show up if linuxkpi.debug is turned on
rather than being silent NOPs.


That said, is the link supposed to go away along with the "file" if
removed or do both need to be removed independently?



+       return (0);
+}
+
static inline int
sysfs_create_files(struct kobject *kobj, const struct attribute * const *attrs)
{


--
Bjoern A. Zeeb                                                     r15:7

Reply via email to